Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/48#discussion_r109236503
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
    @@ -265,6 +254,44 @@ public void cancel() {
       }
     
       @Override
    +  public Cancellable setSecureStoreRenewer(SecureStoreRenewer renewer, 
long initialDelay,
    +                                           long delay, long retryDelay, 
TimeUnit unit) {
    +    synchronized (this) {
    +      if (secureStoreScheduler != null) {
    +        // Shutdown and block until the schedule is stopped
    +        stopScheduler(secureStoreScheduler);
    +
    +        Futures.getUnchecked(secureStoreScheduler.submit(new Runnable() {
    --- End diff --
    
    Strange, I thought I removed it. Looks like some changes are lost. Let me 
double check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to