Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r124117726
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocation.java
---
@@ -162,7 +163,8 @@ public URI toURI() {
// append "port" to the path URI, while the DistributedFileSystem
always use the cluster logical
// name, which doesn't allow having port in it.
URI uri = path.toUri();
- if (HAUtil.isLogicalUri(locationFactory.getConfiguration(), uri)) {
+
+ if
(FileContextLocationUtil.useLogicalUri(locationFactory.getConfiguration(),
uri)) {
--- End diff --
I am not sure it is as simple as that. We may need to change equals() to
compare based on toURI() and not path or somehow make path and toURI() to be in
sync within that class, otherwise parts become inconsistent and I am not sure
unitTests failures in this case is the only issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
