[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087128#comment-16087128 ]
ASF GitHub Bot commented on TWILL-238: -------------------------------------- Github user fonelor commented on a diff in the pull request: https://github.com/apache/twill/pull/56#discussion_r127425262 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java --- @@ -17,15 +17,14 @@ */ package org.apache.twill.api; -import org.apache.twill.api.logging.LogEntry; -import org.apache.twill.api.logging.LogHandler; -import org.apache.twill.discovery.Discoverable; -import org.apache.twill.discovery.ServiceDiscovered; - import java.util.Map; import java.util.Set; import java.util.concurrent.Future; import javax.annotation.Nullable; +import org.apache.twill.api.logging.LogEntry; --- End diff -- i've reverted reformatting changes > Change TwillController restartInstances API > ------------------------------------------- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api > Reporter: Filippov Sergey > Assignee: Filippov Sergey > Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future<String> restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future<String> > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)