[
https://issues.apache.org/jira/browse/TWILL-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113243#comment-16113243
]
ASF GitHub Bot commented on TWILL-237:
--------------------------------------
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r131224027
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocationUtil.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.twill.filesystem;
+
+import com.google.common.base.Throwables;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hdfs.HAUtil;
+
+import java.lang.invoke.MethodHandle;
+import java.lang.invoke.MethodHandles;
+import java.lang.invoke.MethodType;
+import java.net.URI;
+
+/**
+ * Utility class.
+ */
+final class FileContextLocationUtil {
--- End diff --
Thank you for the final review. Addressed your comment
> Twill is using hdfs HAUtil api that is nont-compatible with hadoop 2.8
> ----------------------------------------------------------------------
>
> Key: TWILL-237
> URL: https://issues.apache.org/jira/browse/TWILL-237
> Project: Apache Twill
> Issue Type: Bug
> Components: yarn
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
>
> Twill is using hdfs.HAUtil apis that are suppose to be hdfs private and
> subsequently signature of isLogicalURI was changed (actually name was
> changed) in hadoop version 2.8
> Will post a patch for now to support both old and new names, but I think
> eventually references to private hdfs interfaces/classes should be removed
> from twill
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
