[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119074#comment-16119074
]
ASF GitHub Bot commented on TWILL-240:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132040093
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -267,6 +280,14 @@ void stopByIdAndWait(String runnableName, int
instanceId) {
resourceReport.removeRunnableResources(runnableName, containerId);
containerChange.signalAll();
+ if (eventHandler != null) {
+ Integer exitStatus = containerExitStatus.get(containerId);
+ if (exitStatus == null) {
--- End diff --
So this is for handling the case when `handleCompleted` was not called
(e.g. the runnable container is not stopping after receiving the "stop"
command), right? If that's the case, isn't that the exit status is always not
there?
Also, do we need to do the similar logic to call event handler in the
`stopAll` method?
> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
> Key: TWILL-240
> URL: https://issues.apache.org/jira/browse/TWILL-240
> Project: Apache Twill
> Issue Type: New Feature
> Reporter: Chengfeng Mao
> Assignee: Chengfeng Mao
> Fix For: 0.12.0
>
>
> Application Master should be able to run application specific code when
> certain lifecycle events happen by calling methods from EventHandler. For
> instance, when the app first starts, completes, aborts and etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
