[
https://issues.apache.org/jira/browse/TWILL-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120745#comment-16120745
]
ASF GitHub Bot commented on TWILL-240:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r132322316
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -239,14 +359,8 @@ protected void doStop() throws Exception {
LOG.info("Stop application master with spec: {}",
TwillRuntimeSpecificationAdapter.create().toJson(twillRuntimeSpec));
- if (eventHandler != null) {
- try {
- // call event handler destroy. If there is error, only log and not
affected stop sequence.
- eventHandler.destroy();
- } catch (Throwable t) {
- LOG.warn("Exception when calling {}.destroy()",
eventHandler.getClass().getName(), t);
- }
- }
+ // call event handler destroy
+ eventHandler.destroy();
--- End diff --
Shouldn't call `destroy()` here anymore. It should be called after call
other calls to the event handler, as it is acted as a cleanup call.
> Improve EventHandler to handle more application lifecycle events
> ----------------------------------------------------------------
>
> Key: TWILL-240
> URL: https://issues.apache.org/jira/browse/TWILL-240
> Project: Apache Twill
> Issue Type: New Feature
> Reporter: Chengfeng Mao
> Assignee: Chengfeng Mao
> Fix For: 0.12.0
>
>
> Application Master should be able to run application specific code when
> certain lifecycle events happen by calling methods from EventHandler. For
> instance, when the app first starts, completes, aborts and etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
