[GitHub] twill pull request #65: (TWILL-254) Update to use ContainerId.fromString

[serranom]

Github user serranom commented on a diff in the pull request:

    https://github.com/apache/twill/pull/65#discussion_r165845936
  
    --- Diff: 
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java
 ---
    @@ -71,6 +73,11 @@ public Hadoop20YarnAMClient(Configuration conf) {
         this.nmClient = new Hadoop20YarnNMClient(YarnRPC.create(conf), conf);
       }
     
    +  @Override
    +  private ContainerId containerIdLookup(String containerIdStr) {
    +    return (ConverterUtils.toContainerId(containerIdStr));
    --- End diff --
    
    this should be protected not private


---