[ https://issues.apache.org/jira/browse/TWILL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632850#comment-16632850 ]
Hongyuan Li commented on TWILL-262: ----------------------------------- [~chtyim], can you give me a code review ? seems build failure is not caused by what i cmmited. > YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses, which is > removed from DFSUtils from hadoop-2.8 > ---------------------------------------------------------------------------------------------------------------- > > Key: TWILL-262 > URL: https://issues.apache.org/jira/browse/TWILL-262 > Project: Apache Twill > Issue Type: Bug > Components: yarn > Affects Versions: 0.8.0, 0.9.0, 0.11.0, 0.12.0, 0.13.0 > Reporter: Hongyuan Li > Priority: Major > > YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses, which is > removed from DFSUtils from hadoop-2.8 > current code > {code} > public static void cloneHaNnCredentials(Configuration config) throws > IOException { > …… > // Loop through all name services. Each name service could have multiple > name node associated with it. > for (Map.Entry<String, Map<String, InetSocketAddress>> entry : > DFSUtil.getHaNnRpcAddresses(config).entrySet()) { > String nsId = entry.getKey(); > Map<String, InetSocketAddress> addressesInNN = entry.getValue(); > if (!HAUtil.isHAEnabled(config, nsId) || addressesInNN == null || > addressesInNN.isEmpty()) { > continue; > } > …… > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)