[ 
https://issues.apache.org/jira/browse/TWILL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653178#comment-16653178
 ] 

ASF GitHub Bot commented on TWILL-262:
--------------------------------------

Github user piaosama commented on a diff in the pull request:

    https://github.com/apache/twill/pull/71#discussion_r225824325
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
    @@ -202,6 +223,28 @@ public static void cloneHaNnCredentials(Configuration 
config) throws IOException
         }
       }
     
    +  /***
    +   * When hadoop_version > 2.8.0, class DFSUtils has no method 
getHaNnRpcAddresses(Configuration config)
    --- End diff --
    
    
https://github.com/apache/hadoop/commit/f02ca4ab158aa2257e839a1f74bc8254e1a3d61b#diff-f42f0d7039ba6a4ce427c67ae74dd7ec
    
    HDFS-8185 Separate client related routines in HAUtil into a new clas also 
said this.


> YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses, which is 
> removed from DFSUtils from hadoop-2.8 
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: TWILL-262
>                 URL: https://issues.apache.org/jira/browse/TWILL-262
>             Project: Apache Twill
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 0.8.0, 0.9.0, 0.11.0, 0.12.0, 0.13.0
>            Reporter: Hongyuan Li
>            Priority: Major
>         Attachments: errors.txt
>
>
> YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses, which is 
> removed from DFSUtils from hadoop-2.8 
> current code
> {code}
>   public static void cloneHaNnCredentials(Configuration config) throws 
> IOException {
>     ……
>     // Loop through all name services. Each name service could have multiple 
> name node associated with it.
>     for (Map.Entry<String, Map<String, InetSocketAddress>> entry : 
> DFSUtil.getHaNnRpcAddresses(config).entrySet()) {
>       String nsId = entry.getKey();
>       Map<String, InetSocketAddress> addressesInNN = entry.getValue();
>       if (!HAUtil.isHAEnabled(config, nsId) || addressesInNN == null || 
> addressesInNN.isEmpty()) {
>         continue;
>       }
>  ……
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to