pulling the JIRA discussion up to dev@.

RE log level: interesting reasoning. It raises the question when a log
level should be INFO vs. DEBUG. Having read some of the twill code, my
feeling is that a little bit more INFO would be fine in the Twill codebase.
For me, INFO is representing information useful to anyone following
progress of an application but isn't annoying (forrest instead of trees)
and doesn't represent anomalies (WARN, ERROR), while DEBUG facilitates
getting a deeper inside what's happening beyond simply following along, to
the fact of getting overwhelming (trees instead of forrest).

So, personally, I would rather stick with TWILL-15-5.patch, and move some
DEBUG to INFO elsewhere, but I will also provide an alternative patch.

  Bernd


On Tue, Dec 10, 2013 at 9:12 AM, Terence Yim (JIRA) <[email protected]> wrote:

>
>     [
> https://issues.apache.org/jira/browse/TWILL-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844071#comment-13844071]
>
> Terence Yim commented on TWILL-15:
> ----------------------------------
>
> The constants and logging looks good, except that I think all the new log
> lines should be "debug" rather than "info" to have the same log level as in
> the caller side (YarnTwillPreparer).
>
> > Detailed error message when copy to HDFS fails
> > ----------------------------------------------
> >
> >                 Key: TWILL-15
> >                 URL: https://issues.apache.org/jira/browse/TWILL-15
> >             Project: Apache Twill
> >          Issue Type: Bug
> >            Reporter: Bernd Fondermann
> >         Attachments: TWILL-15-2.patch, TWILL-15-3.patch,
> TWILL-15-5.patch, TWILL-15.patch
> >
> >
> > When the target dir in HDFS does not exist, or the ACLs don't allow
> write access, the copy fails. The related message won't give details, so
> troubleshooting is difficult.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1.4#6159)
>

Reply via email to