----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17434/ -----------------------------------------------------------
Review request for Twill. Repository: twill Description ------- Enable checkstyle plugin and fixes errors and warnings. Diffs ----- checkstyle.xml PRE-CREATION pom.xml 217a0ce twill-api/src/main/java/org/apache/twill/api/LocalFile.java df35a3b twill-api/src/main/java/org/apache/twill/api/ResourceSpecification.java b40682f twill-api/src/main/java/org/apache/twill/api/TwillController.java a5906f4 twill-api/src/main/java/org/apache/twill/api/TwillRunnableSpecification.java bbcc5d7 twill-api/src/main/java/org/apache/twill/api/TwillSpecification.java 00d171d twill-api/src/main/java/org/apache/twill/internal/DefaultEventHandlerSpecification.java df21400 twill-api/src/main/java/org/apache/twill/internal/DefaultLocalFile.java e43c0c0 twill-api/src/main/java/org/apache/twill/internal/DefaultResourceReport.java c4c8a29 twill-api/src/main/java/org/apache/twill/internal/DefaultRuntimeSpecification.java c4f496e twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunnableSpecification.java 14ea7f5 twill-api/src/main/java/org/apache/twill/internal/DefaultTwillSpecification.java 6bb2b15 twill-api/src/main/java/org/apache/twill/internal/RunIds.java 7249d81 twill-common/src/main/java/org/apache/twill/filesystem/Location.java dee9546 twill-core/src/main/java/org/apache/twill/internal/AbstractExecutionServiceController.java 974639d twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java 71f0c14 twill-core/src/main/java/org/apache/twill/internal/AbstractZKServiceController.java 98cc2b8 twill-core/src/main/java/org/apache/twill/internal/Configs.java 0fa1df8 twill-core/src/main/java/org/apache/twill/internal/Constants.java efe91a7 twill-core/src/main/java/org/apache/twill/internal/SingleRunnableApplication.java a52afe1 twill-core/src/main/java/org/apache/twill/internal/TwillContainerController.java 8b090bd twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java dad8cbe twill-core/src/main/java/org/apache/twill/internal/ZKMessages.java 03575dd twill-core/src/main/java/org/apache/twill/internal/ZKServiceDecorator.java d434bac twill-core/src/main/java/org/apache/twill/internal/json/ArgumentsCodec.java 07d4c1d twill-core/src/main/java/org/apache/twill/internal/json/LocalFileCodec.java 680a36c twill-core/src/main/java/org/apache/twill/internal/json/ResourceReportAdapter.java e473fe7 twill-core/src/main/java/org/apache/twill/internal/json/ResourceReportCodec.java 884d889 twill-core/src/main/java/org/apache/twill/internal/json/ResourceSpecificationCodec.java bea73c4 twill-core/src/main/java/org/apache/twill/internal/json/RuntimeSpecificationCodec.java 867f4a8 twill-core/src/main/java/org/apache/twill/internal/json/StateNodeCodec.java c1e9d1c twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java 8951173 twill-core/src/main/java/org/apache/twill/internal/json/TwillRunnableSpecificationCodec.java f37c1e8 twill-core/src/main/java/org/apache/twill/internal/json/TwillSpecificationCodec.java 5d88350 twill-core/src/main/java/org/apache/twill/internal/kafka/EmbeddedKafkaServer.java d82d617 twill-core/src/main/java/org/apache/twill/internal/logging/LogEntryDecoder.java dc11666 twill-core/src/main/java/org/apache/twill/internal/state/MessageCodec.java 176f620 twill-core/src/main/java/org/apache/twill/internal/state/SimpleMessage.java e146e56 twill-core/src/main/java/org/apache/twill/internal/state/StateNode.java d66f8a2 twill-core/src/main/java/org/apache/twill/internal/state/SystemMessages.java 9877121 twill-core/src/main/java/org/apache/twill/kafka/client/KafkaPublisher.java bffce97 twill-core/src/test/java/org/apache/twill/internal/ControllerTest.java 382dc95 twill-core/src/test/java/org/apache/twill/internal/state/MessageCodecTest.java d267cf8 twill-core/src/test/java/org/apache/twill/internal/state/ZKServiceDecoratorTest.java 47d8562 twill-core/src/test/java/org/apache/twill/internal/utils/ApplicationBundlerTest.java 508cadb twill-discovery-core/src/main/java/org/apache/twill/discovery/DefaultServiceDiscovered.java 49fb641 twill-discovery-core/src/main/java/org/apache/twill/discovery/InMemoryDiscoveryService.java 2f950b8 twill-discovery-core/src/main/java/org/apache/twill/discovery/ZKDiscoveryService.java 0543626 twill-discovery-core/src/test/java/org/apache/twill/discovery/DiscoveryServiceTestBase.java 17b526b twill-discovery-core/src/test/java/org/apache/twill/discovery/ZKDiscoveryServiceTest.java 6f0cde0 twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java d98dee1 twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java bfec34e twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnNMClient.java 98ecc67 twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/ports/AllocationResponse.java 89734fc twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/ports/AllocationResponses.java ea46c3b twill-yarn/src/main/hadoop21/org/apache/twill/internal/yarn/Hadoop21YarnAMClient.java ce8f90f twill-yarn/src/main/hadoop21/org/apache/twill/internal/yarn/Hadoop21YarnAppClient.java 50b212d twill-yarn/src/main/hadoop21/org/apache/twill/internal/yarn/Hadoop21YarnNMClient.java d3a6a80 twill-yarn/src/main/java/org/apache/twill/internal/AbstractTwillService.java 47dd07c twill-yarn/src/main/java/org/apache/twill/internal/ServiceMain.java 4ffb023 twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterMain.java b34a7a2 twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterProcessLauncher.java b51bb63 twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java 73cecf0 twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationSubmitter.java 931c5ef twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunnableContainerRequest.java 7f28443 twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunnableProcessLauncher.java b4b27a9 twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java beef0d4 twill-yarn/src/main/java/org/apache/twill/internal/appmaster/TrackerService.java ca299e0 twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerMain.java bbd6c10 twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java f5bc1f2 twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnProcessLauncher.java b810854 twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnAMClient.java 83ba6a8 twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnAppClient.java 71a9e68 twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnApplicationReport.java 4dbb1d1 twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnContainerStatus.java 57e712c twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnLaunchContext.java 984a1be twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnNMClient.java d863c91 twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java 4f7597b twill-yarn/src/main/java/org/apache/twill/yarn/LocationSecureStoreUpdater.java 4d20c9c twill-yarn/src/main/java/org/apache/twill/yarn/ResourceReportClient.java 2974c3f twill-yarn/src/main/java/org/apache/twill/yarn/YarnSecureStore.java e6f461a twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java 4c240fb twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java baa5740 twill-yarn/src/test/java/org/apache/twill/yarn/BaseYarnTest.java 6943ef9 twill-yarn/src/test/java/org/apache/twill/yarn/DistributeShellTestRun.java 0ed496e twill-yarn/src/test/java/org/apache/twill/yarn/DistributedShell.java 2f42e31 twill-yarn/src/test/java/org/apache/twill/yarn/EchoServerTestRun.java a14b326 twill-yarn/src/test/java/org/apache/twill/yarn/FailureRestartTestRun.java 8bc9571 twill-yarn/src/test/java/org/apache/twill/yarn/LocalFileTestRun.java d7e186f twill-yarn/src/test/java/org/apache/twill/yarn/ProvisionTimeoutTestRun.java d5e3fc3 twill-yarn/src/test/java/org/apache/twill/yarn/SocketServer.java dabdc07 twill-yarn/src/test/java/org/apache/twill/yarn/TaskCompletedTestRun.java 37fc8aa twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/BasicNodeChildren.java 9e4f55f twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/BasicNodeData.java 98a3a66 twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/DefaultZKClientService.java c52fb08 twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/FailureRetryZKClient.java 65ceadb twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/NamespaceZKClient.java 1a82e4b twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/RewatchOnExpireWatcher.java 181ca2b twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/RewatchOnExpireZKClient.java 402c153 twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/SettableOperationFuture.java 7544e56 twill-zookeeper/src/main/java/org/apache/twill/zookeeper/ZKClientService.java 63f27fb twill-zookeeper/src/main/java/org/apache/twill/zookeeper/ZKOperations.java 6dcd1a7 twill-zookeeper/src/test/java/org/apache/twill/zookeeper/ZKClientTest.java f1db74a Diff: https://reviews.apache.org/r/17434/diff/ Testing ------- Thanks, Terence Yim
