----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18146/#review34576 -----------------------------------------------------------
Ship it! Looks good except for one minor comment. - Andreas Neumann On Feb. 14, 2014, 9:46 p.m., Terence Yim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18146/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 9:46 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Make AM not to re-launch container that failed at initialize stage > > > Diffs > ----- > > twill-api/src/main/java/org/apache/twill/api/TwillRunnable.java 4350bfb > twill-yarn/src/main/java/org/apache/twill/internal/ContainerExitCodes.java > PRE-CREATION > twill-yarn/src/main/java/org/apache/twill/internal/ServiceMain.java 4831158 > > twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java > 57c58da > twill-yarn/src/test/java/org/apache/twill/yarn/InitializeFailTestRun.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18146/diff/ > > > Testing > ------- > > > Thanks, > > Terence Yim > >
