----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18209/#review35018 -----------------------------------------------------------
Ship it! Ship It! - Terence Yim On Feb. 20, 2014, 10:57 a.m., Fabian Murariu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18209/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 10:57 a.m.) > > > Review request for Twill and Terence Yim. > > > Bugs: TWILL-40 > https://issues.apache.org/jira/browse/TWILL-40 > > > Repository: twill > > > Description > ------- > > made changes as per review #18209 for #TWILL-40 rev2 > > > made changes as per review #18209 for #TWILL-40 > > > Merge branch 'master' of > https://git-wip-us.apache.org/repos/asf/incubator-twill into figureout > > > fixing checkstyle violations #TWILL-40 > > > Merge branch 'master' of > https://git-wip-us.apache.org/repos/asf/incubator-twill into figureout > > > exposes the YARN client ContainerRequest hosts and racks options into > ResourceSpecification #TWILL-40 > > > Diffs > ----- > > pom.xml 214100077e36f40736216433aa0c3791b706afdb > twill-api/src/main/java/org/apache/twill/api/ResourceSpecification.java > 0bab8110c3662e5bf87f3e0ac6cee60e77cccf60 > > twill-api/src/main/java/org/apache/twill/internal/DefaultResourceSpecification.java > 1327ce56aff5c9ca481afc65086950648974075f > twill-core/pom.xml 859c65335afe3adfebcaace249174ecf1d197df3 > > twill-core/src/main/java/org/apache/twill/internal/json/ResourceSpecificationCodec.java > d3b9707ca9afa058ea0c3b135886cfd22d7ed9db > > twill-core/src/test/java/org/apache/twill/internal/json/ResourceSpecificationCodecTest.java > PRE-CREATION > > twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java > 7caedad42fd6b4c2c32153826e6e48db6613df80 > twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnAMClient.java > b0dbce0ebfb990950fc9cf2d5d63914bea7f14e4 > > Diff: https://reviews.apache.org/r/18209/diff/ > > > Testing > ------- > > > Thanks, > > Fabian Murariu > >
