----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18864/#review36572 -----------------------------------------------------------
twill-core/src/main/java/org/apache/twill/internal/ZKServiceDecorator.java <https://reviews.apache.org/r/18864/#comment67575> Does this happen often? Perhaps info will create very verbose logging here? twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java <https://reviews.apache.org/r/18864/#comment67574> should this be "submitted"? twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java <https://reviews.apache.org/r/18864/#comment67576> Can you explain somewhere what it means when this happens? How can it get into a state where the zk node is gone? - Andreas Neumann On March 6, 2014, 9:57 p.m., Terence Yim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18864/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 9:57 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Fix for issue TWILL-52 > > > Diffs > ----- > > > twill-core/src/main/java/org/apache/twill/internal/AbstractZKServiceController.java > a132128 > > twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java > 5d2f33c > twill-core/src/main/java/org/apache/twill/internal/ZKServiceDecorator.java > 7592176 > twill-core/src/test/java/org/apache/twill/internal/ControllerTest.java > 048e489 > twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java > 8e0c6be > twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java > 9dff24d > twill-yarn/src/test/java/org/apache/twill/yarn/SessionExpireTestRun.java > PRE-CREATION > twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java bed613a > twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestUtils.java 079db56 > > Diff: https://reviews.apache.org/r/18864/diff/ > > > Testing > ------- > > Added new test case SessionExpireTestRun with all existing test cases passed > on all profiles. > > > Thanks, > > Terence Yim > >
