----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19557/#review38241 -----------------------------------------------------------
Ship it! Ship It! - Andreas Neumann On March 21, 2014, 11:40 p.m., Terence Yim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19557/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 11:40 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Enhance Location API to add support for listing directory content and also > check if a location is directory. > > > Diffs > ----- > > twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java > d107eac > twill-common/src/main/java/org/apache/twill/filesystem/Location.java > a2d1f9a > > twill-common/src/test/java/org/apache/twill/filesystem/LocalLocationTest.java > 198f77f > twill-yarn/src/main/java/org/apache/twill/filesystem/HDFSLocation.java > b0eeb43 > twill-yarn/src/test/java/org/apache/twill/filesystem/HDFSLocationTest.java > PRE-CREATION > twill-yarn/src/test/java/org/apache/twill/filesystem/LocalLocationTest.java > PRE-CREATION > twill-yarn/src/test/java/org/apache/twill/filesystem/LocationTestBase.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19557/diff/ > > > Testing > ------- > > Added new test HDFSLocationTest that uses MiniDFSCluster to test. > > > Thanks, > > Terence Yim > >
