> On April 12, 2014, 1:32 a.m., Terence Yim wrote: > > twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java, > > line 277 > > <https://reviews.apache.org/r/20274/diff/1/?file=555458#file555458line277> > > > > Why need a Supplier of String? String is immutable.
Oh, that is what was there before TWILL-70. Here I simply reverted it and added the debug option to the preparer instead. I will remove the supplier. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20274/#review40194 ----------------------------------------------------------- On April 12, 2014, 12:53 a.m., Andreas Neumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20274/ > ----------------------------------------------------------- > > (Updated April 12, 2014, 12:53 a.m.) > > > Review request for Twill. > > > Bugs: TWILL-71 > https://issues.apache.org/jira/browse/TWILL-71 > > > Repository: twill > > > Description > ------- > > See https://issues.apache.org/jira/browse/TWILL-71 > > > Diffs > ----- > > twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java b2a3ce2 > twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java > a02efea > twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java > 4ecfb0e > twill-yarn/src/test/java/org/apache/twill/yarn/DebugTestRun.java ee98352 > twill-yarn/src/test/java/org/apache/twill/yarn/LocalFileTestRun.java > 78f61a9 > > Diff: https://reviews.apache.org/r/20274/diff/ > > > Testing > ------- > > unit tests did not change. > > > Thanks, > > Andreas Neumann > >
