----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20436/#review40633 -----------------------------------------------------------
Ship it! Very minor remarks. Overall looks great. twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java <https://reviews.apache.org/r/20436/#comment73705> Almost feels like this should be a YarnUtil, too. twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java <https://reviews.apache.org/r/20436/#comment73706> same here twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java <https://reviews.apache.org/r/20436/#comment73707> nice. thanks for the good comment - Andreas Neumann On April 17, 2014, 12:18 a.m., Terence Yim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20436/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 12:18 a.m.) > > > Review request for Twill and Andreas Neumann. > > > Repository: twill > > > Description > ------- > > Review for TWILL-73 > > > Diffs > ----- > > > twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAMClient.java > 68d073d > > twill-yarn/src/main/hadoop21/org/apache/twill/internal/yarn/Hadoop21YarnAMClient.java > 0ebc0f5 > > twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java > f1ad20e > > twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java > PRE-CREATION > twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnAMClient.java > 370ca3c > twill-yarn/src/test/java/org/apache/twill/yarn/ContainerSizeTestRun.java > PRE-CREATION > twill-yarn/src/test/java/org/apache/twill/yarn/LogHandlerTestRun.java > 4d45ad1 > > Diff: https://reviews.apache.org/r/20436/diff/ > > > Testing > ------- > > New test ContainerSizeTestRun has been added and verified the broken behavior > in old code and fixed in this patch. > > > Thanks, > > Terence Yim > >
