----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22464/#review47405 -----------------------------------------------------------
Ship it! LGTM. Ship it. - Terence Yim On July 3, 2014, 5:40 p.m., Gary Helmling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22464/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 5:40 p.m.) > > > Review request for Twill. > > > Bugs: TWILL-85 > https://issues.apache.org/jira/browse/TWILL-85 > > > Repository: twill > > > Description > ------- > > Adds a LeaderElection implementation for Twill and exposes it to applications > through TwillContext. > > > Diffs > ----- > > twill-api/src/main/java/org/apache/twill/api/ElectionHandler.java > PRE-CREATION > twill-api/src/main/java/org/apache/twill/api/TwillContext.java f7a7ac1 > twill-core/src/main/java/org/apache/twill/internal/BasicTwillContext.java > 4a503e0 > twill-core/src/main/java/org/apache/twill/internal/ElectionRegistry.java > PRE-CREATION > > twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerMain.java > c3aece6 > > twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java > b212a29 > twill-zookeeper/pom.xml 1b37cc5 > > twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/LeaderElection.java > PRE-CREATION > > twill-zookeeper/src/test/java/org/apache/twill/internal/zookeeper/LeaderElectionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22464/diff/ > > > Testing > ------- > > > Thanks, > > Gary Helmling > >
