[ 
https://issues.apache.org/jira/browse/TWILL-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292281#comment-14292281
 ] 

ASF GitHub Bot commented on TWILL-80:
-------------------------------------

Github user anew commented on the pull request:

    https://github.com/apache/incubator-twill/pull/20#issuecomment-71520988
  
    The changes look good to me. Though it is a lot of refactoring, and hard to 
verify that the new code actually does what the previous code did, but with 
correct ordering of services lifecycle. Nice new test case to validate that it 
actually fixes this bug. 
    
    +1 provided all tests pass. 


> Logs not available when the runnable failed at initialize or only runs 
> momentarily 
> -----------------------------------------------------------------------------------
>
>                 Key: TWILL-80
>                 URL: https://issues.apache.org/jira/browse/TWILL-80
>             Project: Apache Twill
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.2.0-incubating
>            Reporter: Terence Yim
>            Assignee: Terence Yim
>             Fix For: 0.5.0-incubating
>
>
> Multiple users reported this issue. Need to investigate and fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to