[
https://issues.apache.org/jira/browse/TWILL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319283#comment-14319283
]
ASF GitHub Bot commented on TWILL-115:
--------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/24#discussion_r24634006
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ProcessLauncher.java ---
@@ -44,51 +44,29 @@
*/
interface PrepareLaunchContext {
- ResourcesAdder withResources();
-
- AfterResources noResources();
-
- interface ResourcesAdder {
- MoreResources add(LocalFile localFile);
- }
-
- interface AfterResources {
- EnvironmentAdder withEnvironment();
-
- AfterEnvironment noEnvironment();
- }
-
- interface EnvironmentAdder {
- <V> MoreEnvironment add(String key, V value);
- }
-
- interface MoreEnvironment extends EnvironmentAdder, AfterEnvironment {
- }
-
- interface AfterEnvironment {
- CommandAdder withCommands();
- }
-
- interface MoreResources extends ResourcesAdder, AfterResources { }
-
- interface CommandAdder {
- StdOutSetter add(String cmd, String...args);
- }
-
- interface StdOutSetter {
- StdErrSetter redirectOutput(String stdout);
-
- StdErrSetter noOutput();
- }
-
- interface StdErrSetter {
- MoreCommand redirectError(String stderr);
-
- MoreCommand noError();
- }
-
- interface MoreCommand extends CommandAdder {
- <R> ProcessController<R> launch();
- }
+ /**
--- End diff --
so this part of the change is simplifying the builder, right? is it
backward-compatible with existing code? If PrepareLaunchContext simply provides
the superset of the previous More/Setter/Adder interfaces, then I guess it is?
> Add support to submit jobs to non-default YARN queue
> ----------------------------------------------------
>
> Key: TWILL-115
> URL: https://issues.apache.org/jira/browse/TWILL-115
> Project: Apache Twill
> Issue Type: Improvement
> Reporter: Poorna Chandra
> Assignee: Terence Yim
> Fix For: 0.5.0-incubating
>
>
> Today Twill only submits job to default queue in YARN. It would be useful to
> allow job submissions to non-default queues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
