Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/24#discussion_r24634006
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ProcessLauncher.java ---
@@ -44,51 +44,29 @@
*/
interface PrepareLaunchContext {
- ResourcesAdder withResources();
-
- AfterResources noResources();
-
- interface ResourcesAdder {
- MoreResources add(LocalFile localFile);
- }
-
- interface AfterResources {
- EnvironmentAdder withEnvironment();
-
- AfterEnvironment noEnvironment();
- }
-
- interface EnvironmentAdder {
- <V> MoreEnvironment add(String key, V value);
- }
-
- interface MoreEnvironment extends EnvironmentAdder, AfterEnvironment {
- }
-
- interface AfterEnvironment {
- CommandAdder withCommands();
- }
-
- interface MoreResources extends ResourcesAdder, AfterResources { }
-
- interface CommandAdder {
- StdOutSetter add(String cmd, String...args);
- }
-
- interface StdOutSetter {
- StdErrSetter redirectOutput(String stdout);
-
- StdErrSetter noOutput();
- }
-
- interface StdErrSetter {
- MoreCommand redirectError(String stderr);
-
- MoreCommand noError();
- }
-
- interface MoreCommand extends CommandAdder {
- <R> ProcessController<R> launch();
- }
+ /**
--- End diff --
so this part of the change is simplifying the builder, right? is it
backward-compatible with existing code? If PrepareLaunchContext simply provides
the superset of the previous More/Setter/Adder interfaces, then I guess it is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
