GitHub user rob-morgan opened a pull request:
https://github.com/apache/incubator-twill/pull/28
(TWILL-125) Eliminate mainObject instance in BundedJarRunner
Instantiating the object containing the main method in order to invoke
the main method is unnecessary since main is always static. There is
also a potential problem with calling newInstance() on the main object's
class; it will throw an exception if the main object does not have
a 0-args constructor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob-morgan/incubator-twill master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit ca5877995e92da081c16e3f273f3e22e346e3c38
Author: Rob Morgan <[email protected]>
Date: 2015-03-23T16:08:57Z
(TWILL-125) Eliminate mainObject instance in BundedJarRunner
Instantiating the object containing the main method in order to invoke
the main method is unnecessary since main is always static. There is
also a potential problem with calling newInstance() on the main object's
class; it will throw an exception if the main object does not have
a 0-args constructor.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
