[
https://issues.apache.org/jira/browse/TWILL-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380284#comment-14380284
]
ASF GitHub Bot commented on TWILL-112:
--------------------------------------
Github user ghelmling commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/27#discussion_r27143820
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ApplicationBundler.java ---
@@ -175,6 +175,9 @@ public String apply(Class<?> input) {
if (classLoader == null) {
classLoader = getClass().getClassLoader();
}
+
+ // Record the set of classpath URL that are already added to the jar
+ final Set<URL> seensClassPaths = Sets.newHashSet();
--- End diff --
nit: "seensClassPaths" should be "seenClassPaths" or "addedClassPaths"
> Improve ApplicationBundler performance
> --------------------------------------
>
> Key: TWILL-112
> URL: https://issues.apache.org/jira/browse/TWILL-112
> Project: Apache Twill
> Issue Type: Improvement
> Affects Versions: 0.2.0-incubating, 0.1.0-incubating, 0.3.0-incubating,
> 0.4.0-incubating
> Reporter: Terence Yim
> Assignee: Terence Yim
> Fix For: 0.6.0-incubating
>
>
> The ApplicationBundler doesn't check for duplicate directory before scanning
> the directory recursively, resulting in a lot of time being wasted in just
> scanning and then figured that each file under the directory has been added
> to the final jar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
