[
https://issues.apache.org/jira/browse/TWILL-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529247#comment-14529247
]
ASF GitHub Bot commented on TWILL-69:
-------------------------------------
GitHub user chtyim opened a pull request:
https://github.com/apache/incubator-twill/pull/32
(TWILL-69) Removed guava dependencies from twill-api and twill-common
modules
Following changes are backward incompatible:
- TwillController no longer extends from Guava Service
- No more start() method. stopAndWait() becomes terminate()
- TwillRunnerService no longer extends from Guava Service
- Only has the blocking start() and stop() for start and stop.
- Classes moved from twill-common to twill-core, hence no long public
- o.a.t.common.Services
- o.a.t.common.ServiceListenerAdapter
- o.a.t.common.CompositeService
- o.a.t.common.DefaultResourceReport
Modified all unit-tests and examples to use the new API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/incubator-twill feature/TWILL-69
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 0d217b6d499a901c2a62a5856a042130378be8ca
Author: Terence Yim <[email protected]>
Date: 2015-05-05T02:23:37Z
(TWILL-69) Removed guava dependencies from twill-api and twill-common
modules
Following changes are backward incompatible:
- TwillController no longer extends from Guava Service
- No more start() method. stopAndWait() becomes terminate()
- TwillRunnerService no longer extends from Guava Service
- Only has the blocking start() and stop() for start and stop.
- Classes moved from twill-common to twill-core, hence no long public
- o.a.t.common.Services
- o.a.t.common.ServiceListenerAdapter
- o.a.t.common.CompositeService
- o.a.t.common.DefaultResourceReport
Modified all unit-tests and examples to use the new API
----
> Remove guava dependencies on the twill-api and twill-common modules
> -------------------------------------------------------------------
>
> Key: TWILL-69
> URL: https://issues.apache.org/jira/browse/TWILL-69
> Project: Apache Twill
> Issue Type: Improvement
> Components: api
> Reporter: Terence Yim
>
> Currently twill-api and twill-common has dependencies on guava (mainly for
> Service interface and some collection helpers). The dependencies could
> sometime causes conflicts to twill apps.
> By removing the guava dependencies from twill-api and twill-common, which are
> the only modules that twill app would depends on (not the client, but the
> implementation of TwillRunnable), together with the Bundled Jar support, one
> could easily write and run twill apps without worrying about dependencies
> conflict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
