Henry Saputra created TWILL-136:
-----------------------------------
Summary: Override equals and hashCode for JvmOptions.DebugOptions
to test equality
Key: TWILL-136
URL: https://issues.apache.org/jira/browse/TWILL-136
Project: Apache Twill
Issue Type: Bug
Components: core
Reporter: Henry Saputra
The current code for JvmOptions.DebugOptions does not have equals and hashCode
overriden for equality test.
This would cause fail comparison for DebugOptions.NO_DEBUG when being used in
YarnTwillPreparer:
{code:java}
final class YarnTwillPreparer implements TwillPreparer {
...
@Override
public TwillPreparer enableDebugging(boolean doSuspend, String... runnables) {
this.debugOptions = new JvmOptions.DebugOptions(true, doSuspend,
ImmutableSet.copyOf(runnables));
return this;
}
....
if ((extraOptions == null || extraOptions.isEmpty()) &&
JvmOptions.DebugOptions.NO_DEBUG.equals(debugOptions)) {
// If no vm options, no need to localize the file.
return;
}
...
}
{code:java}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
