Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/43#discussion_r32689750
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/JvmOptions.java ---
@@ -83,5 +84,36 @@ public boolean doSuspend() {
public boolean doDebug(String runnable) {
return doDebug && (runnables == null ||
runnables.contains(runnable));
}
+
+ @Override
+ public boolean equals(Object object) {
+ if (this == object) {
+ return true;
+ }
+ if (!(object instanceof DebugOptions)) {
+ return false;
+ }
+
+ DebugOptions that = (DebugOptions) object;
+ return (this.doDebug == that.doDebug()) && (this.doSuspend ==
this.doSuspend()) &&
+ (this.runnables != null ? ((that.getRunnables() != null) &&
this.getRunnables().equals(that.getRunnables())) :
+ (that.getRunnables() == null));
+ }
+
+ @Override
+ public int hashCode() {
+ int hash = 17;
--- End diff --
same here, you could use Objects.hashCode()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
