[
https://issues.apache.org/jira/browse/TWILL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591029#comment-14591029
]
ASF GitHub Bot commented on TWILL-136:
--------------------------------------
Github user anew commented on the pull request:
https://github.com/apache/incubator-twill/pull/43#issuecomment-112995927
+1
> Override equals and hashCode for JvmOptions.DebugOptions to test equality
> -------------------------------------------------------------------------
>
> Key: TWILL-136
> URL: https://issues.apache.org/jira/browse/TWILL-136
> Project: Apache Twill
> Issue Type: Bug
> Components: core
> Reporter: Henry Saputra
> Assignee: Henry Saputra
>
> The current code for JvmOptions.DebugOptions does not have equals and
> hashCode overriden for equality test.
> This would cause fail comparison for DebugOptions.NO_DEBUG when being used in
> YarnTwillPreparer:
> {code}
> final class YarnTwillPreparer implements TwillPreparer {
> ...
> @Override
> public TwillPreparer enableDebugging(boolean doSuspend, String...
> runnables) {
> this.debugOptions = new JvmOptions.DebugOptions(true, doSuspend,
> ImmutableSet.copyOf(runnables));
> return this;
> }
> ....
> private void saveJvmOptions(Map<String, LocalFile> localFiles) throws
> IOException {
> if ((extraOptions == null || extraOptions.isEmpty()) &&
> JvmOptions.DebugOptions.NO_DEBUG.equals(this.debugOptions)) {
> // If no vm options, no need to localize the file.
> return;
> }
> ...
> }
> ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
