[
https://issues.apache.org/jira/browse/TWILL-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596577#comment-14596577
]
ASF GitHub Bot commented on TWILL-137:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/46#discussion_r32978614
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -56,7 +56,8 @@
/**
* Get a snapshot of the resources used by the application, broken down
by each runnable.
*
- * @return A {@link ResourceReport} containing information about
resources used by the application.
+ * @return A {@link ResourceReport} containing information about
resources used by the application or
+ * null in case the user calls this before the application
completely starts.
*/
ResourceReport getResourceReport();
--- End diff --
Mark the method with `@Nullable` as well since it can return null.
> Be able to get log level for each runnable via
> TwillController.getResourceReport
> --------------------------------------------------------------------------------
>
> Key: TWILL-137
> URL: https://issues.apache.org/jira/browse/TWILL-137
> Project: Apache Twill
> Issue Type: Improvement
> Components: api, core
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
>
> With TWILL-24 resolved, the client should be able to get the log level for an
> application broken down by each runnable.
> This would involve adding log level to TwillRunResources interface and its
> implementations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
