Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/49#discussion_r33535438
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/ApplicationBundler.java ---
    @@ -99,7 +87,41 @@ public ApplicationBundler(Iterable<String> 
excludePackages, Iterable<String> inc
         }
         this.bootstrapClassPaths = builder.build();
         this.crc32 = new CRC32();
    +  }
    +
    +  /**
    +   * Constructs a ApplicationBundler.
    +   *
    +   * @param excludePackages Class packages to exclude
    +   */
    +  public ApplicationBundler(Iterable<String> excludePackages) {
    +    this(excludePackages, ImmutableList.<String>of());
    +  }
     
    +  /**
    +   * Constructs a ApplicationBundler.
    +   *
    +   * @param excludePackages Class packages to exclude
    +   * @param includePackages Class packages that should be included. 
Anything in this list will override the
    +   *                        one provided in excludePackages.
    +   */
    +  public ApplicationBundler(final Iterable<String> excludePackages, final 
Iterable<String> includePackages) {
    +    this(new Predicate<String>() {
    +      @Override
    +      public boolean apply(@Nullable String className) {
    --- End diff --
    
    +1 removing Nullable annotation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to