[
https://issues.apache.org/jira/browse/TWILL-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621147#comment-14621147
]
ASF GitHub Bot commented on TWILL-116:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/52#discussion_r34296089
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -61,4 +63,22 @@
*/
@Nullable
ResourceReport getResourceReport();
+
+ /**
+ * Restart all instances of a particular {@link TwillRunnable} instance.
+ *
+ * @param runnable The name of the runnable to restart.
+ * @return A {@link Future} that will be completed when the restart
operation has been done. Either successful
+ * or fail, the instance of the future will contains the
information.
+ */
+ Future<List<UpdateRunnableStateResult>>
restartAllRunnableInstances(String runnable);
+
+ /**
+ *
+ * @param runnableToInstanceIds A map of runnable ID to list of instance
IDs to be restarted.
+ * @return A {@link Future} that will be completed when the restart
operation has been done.
+ * Either successful or fail, the instance of the future will
contains the information.
+ */
+ Future<Map<String, List<UpdateRunnableStateResult>>>
restartRunnableInstances(
--- End diff --
So this one is for starting multiple runnable instances, right? Would it be
more convenient to have a method that restart runnable instance(s)? something
like:
```restart(String runnable, int instanceId, int...moreInstanceIds)```
> Support for restart instances of runnable in an application
> -----------------------------------------------------------
>
> Key: TWILL-116
> URL: https://issues.apache.org/jira/browse/TWILL-116
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Albert Shau
> Assignee: Henry Saputra
> Fix For: 0.6.0-incubating
>
> Attachments: TWILL-116-design-4.pdf, TWILL-116-design-5.pdf,
> TWILL-116-design-6.pdf, TWILL-116-design-7.pdf, TWILL-116-design-final-2.pdf
>
>
> Once an application is running, it would be good to be able to stop, start,
> and restart a specific runnable of the application without affecting other
> runnables.
> For example, I may be running multiple services in a single application, with
> each service as a different runnable. One of my services gets into an invalid
> state. I now want to restart just that runnable and not the other ones that
> are running properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
