Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/52#discussion_r34409405
  
    --- Diff: 
twill-yarn/src/test/java/org/apache/twill/yarn/EchoServerTestRun.java ---
    @@ -107,6 +112,30 @@ public void run() {
         controller.changeInstances("EchoServer", 2);
         Assert.assertTrue(waitForSize(echoServices, 2, 120));
     
    +    // Test restart on instances for runnable
    +
    +    TimeUnit.SECONDS.sleep(6L);
    --- End diff --
    
    Yes, that was the intention. Agree about the proposed change and makes the 
test more deterministic. Will change to poll resource report with short sleep.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to