[
https://issues.apache.org/jira/browse/TWILL-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630303#comment-14630303
]
ASF GitHub Bot commented on TWILL-142:
--------------------------------------
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-twill/pull/56
(TWILL-142) Add longer time for timeout in EchoServerTestRun to check
whether the restart successful.
Bump up the timout for stopwatch to wait until all containers have been
restarted.
With new feature in TWILL-116 being committed, the EchoServerTestRun test
become bit flaky due to
sometimes the mini cluster could not allocate new containers in current
proposed timeout which is 30s.
Also fix logging for the test to log info when you get different set of
containers instead of error.
Run test with Travis without the change 5 times we got 2 error because of
container id same in EchoServerTestRun restart test.
With the fix, run 12 times Travis build and 100% NO error in the
EchoServerTestRun restart test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-twill
increase_wait_for_restart_instances
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit a584d1c9b0b7980451df11f8bbe851d047d6a4cb
Author: hsaputra <[email protected]>
Date: 2015-07-15T22:59:05Z
(TWILL-142) Add longer time for timeout in EchoServerTestRun to check
whether the restart successful.
Bump up the timout for stopwatch to wait until all containers have been
restarted.
With new feature in TWILL-116 being committed, the EchoServerTestRun test
become bit flaky due to
sometimes the mini cluster could not allocate new containers in current
proposed timeout which is 30s.
----
> Add longer time for timeout in EchoServerTestRun to check whether the restart
> successful
> ----------------------------------------------------------------------------------------
>
> Key: TWILL-142
> URL: https://issues.apache.org/jira/browse/TWILL-142
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 0.6.0-incubating
> Reporter: Henry Saputra
> Assignee: Henry Saputra
>
> With new feature in TWILL-116 being committed, the EchoServerTestRun test
> become bit flaky due to sometimes the mini cluster could not allocate new
> containers in current proposed timeout which is 30s.
> Bump it to longer time, with milliseconds polling, to make sure enough time
> to allocate new containers on restart.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
