[
https://issues.apache.org/jira/browse/TWILL-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648031#comment-14648031
]
ASF GitHub Bot commented on TWILL-145:
--------------------------------------
Github user chtyim commented on the pull request:
https://github.com/apache/incubator-twill/pull/58#issuecomment-126417421
Just one comment, rest LGTM.
> Potential race condition when restart all is called for a Twill runnable
> ------------------------------------------------------------------------
>
> Key: TWILL-145
> URL: https://issues.apache.org/jira/browse/TWILL-145
> Project: Apache Twill
> Issue Type: Bug
> Components: yarn
> Affects Versions: 0.6.0-incubating
> Reporter: Henry Saputra
> Assignee: Henry Saputra
>
> Found this issue from careful eyes of [~chtyim]
> When sending restart instance to all for a particular TwillRunnable, it could
> have race condition where the heartbeat thread run right after all containers
> have been released which make the check:
> {code}
> // Looks for containers requests.
> if (provisioning.isEmpty() && runnableContainerRequests.isEmpty() &&
> runningContainers.isEmpty()) {
> LOG.info("All containers completed. Shutting down application
> master.");
> break;
> }
> {code}
> This could happen when all running containers are empty and new
> runnableContainerRequests has not been added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
