Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/63#discussion_r40233924
--- Diff:
twill-zookeeper/src/test/java/org/apache/twill/zookeeper/ZKClientTest.java ---
@@ -188,12 +189,21 @@ public void process(WatchedEvent event) {
client.startAndWait();
try {
- final BlockingQueue<Watcher.Event.EventType> events = new
LinkedBlockingQueue<Watcher.Event.EventType>();
+ final BlockingQueue<Watcher.Event.EventType> events = new
LinkedBlockingQueue<>();
--- End diff --
This line is just code cleanup. The modification to this test case is a fix
to make the race condition go away. This test used to fail easily in travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
