[
https://issues.apache.org/jira/browse/TWILL-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940417#comment-14940417
]
ASF GitHub Bot commented on TWILL-151:
--------------------------------------
Github user gsps1 commented on the pull request:
https://github.com/apache/incubator-twill/pull/65#issuecomment-144849505
This would not solve the issue described in Twill-151.
after the kafka server has stopped and before ``terminate()`` is called,
the status would be in running ( ``running`` is set to false in
``terminate()``). we would receive ``java.net.ConnectException: Connection
refused`` , that case is not handled by the patch.
can you update your patch to handle that case? Thanks for the PR.
> Improve Logging error when fetching message after Kafka server is stopped
> -------------------------------------------------------------------------
>
> Key: TWILL-151
> URL: https://issues.apache.org/jira/browse/TWILL-151
> Project: Apache Twill
> Issue Type: Bug
> Reporter: Shankar Selvam
>
> when we add LogHandler, We start a Kafka Consumer thread in Client that polls
> Kafka Server (Started when AM Starts).
> When the AM stops, we stop the kafka server, but there can be race where we
> make request to fetch message from the KafkaConsumer after the Kafka Server
> is stopped. We log the stack-trace in this case and it can be confusing for
> the user, we can improve the error logging in this case to make it cleaner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
