[ 
https://issues.apache.org/jira/browse/TWILL-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947770#comment-14947770
 ] 

ASF GitHub Bot commented on TWILL-63:
-------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/66#discussion_r41459295
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/ApplicationBundler.java ---
    @@ -122,15 +122,16 @@ public boolean accept(String className, URL classUrl, 
URL classPathUrl) {
         });
       }
     
    -  public void createBundle(Location target, Iterable<Class<?>> classes) 
throws IOException {
    -    createBundle(target, classes, ImmutableList.<URI>of());
    +  public void createBundle(Location target, Iterable<Class<?>> classes, 
boolean skipTwillClasses) throws IOException {
    --- End diff --
    
    Why need to introduce this specific boolean? Can't we use the constructor 
that takes `ClassAcceptor`?


> Speed up application launch time
> --------------------------------
>
>                 Key: TWILL-63
>                 URL: https://issues.apache.org/jira/browse/TWILL-63
>             Project: Apache Twill
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 0.2.0-incubating
>            Reporter: Terence Yim
>            Assignee: Shankar Selvam
>             Fix For: 0.7.0-incubating
>
>
> Currently when launching an application, two new jars are always created 
> locally, one for AM (appMaster.jar) and one for Container (container.jar) and 
> copied to HDFS before submitting the application. The jar files could 
> potentially be big and if it doesn't changed, it should require copying to 
> HDFS again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to