[
https://issues.apache.org/jira/browse/TWILL-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949563#comment-14949563
]
ASF GitHub Bot commented on TWILL-24:
-------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/39#discussion_r41579915
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -287,18 +296,20 @@ public TwillController start() {
// appMaster.jar
// org.apache.twill.internal.appmaster.ApplicationMasterMain
// false
- return launcher.prepareLaunch(
- ImmutableMap.<String, String>builder()
- .put(EnvKeys.TWILL_FS_USER, fsUser)
- .put(EnvKeys.TWILL_APP_DIR,
getAppLocation().toURI().toASCIIString())
- .put(EnvKeys.TWILL_ZK_CONNECT,
zkClient.getConnectString())
- .put(EnvKeys.TWILL_RUN_ID, runId.getId())
- .put(EnvKeys.TWILL_RESERVED_MEMORY_MB,
Integer.toString(reservedMemory))
- .put(EnvKeys.TWILL_APP_NAME, twillSpec.getName())
- .put(EnvKeys.YARN_RM_SCHEDULER_ADDRESS,
yarnConfig.get(YarnConfiguration.RM_SCHEDULER_ADDRESS))
- .build(),
- localFiles.values(), credentials
- ).addCommand(
+ ImmutableMap.Builder<String, String> builder =
ImmutableMap.<String, String>builder()
+ .put(EnvKeys.TWILL_FS_USER, fsUser)
+ .put(EnvKeys.TWILL_APP_DIR,
getAppLocation().toURI().toASCIIString())
+ .put(EnvKeys.TWILL_ZK_CONNECT, zkClient.getConnectString())
+ .put(EnvKeys.TWILL_RUN_ID, runId.getId())
+ .put(EnvKeys.TWILL_RESERVED_MEMORY_MB,
Integer.toString(reservedMemory))
+ .put(EnvKeys.TWILL_APP_NAME, twillSpec.getName())
+ .put(EnvKeys.YARN_RM_SCHEDULER_ADDRESS,
yarnConfig.get(YarnConfiguration.RM_SCHEDULER_ADDRESS));
+ if (logLevel != null) {
--- End diff --
Ah, seemed this is a version of code when I did not have the log level as
part of constructor. Right now it will never be null.
> log level should be settable
> ----------------------------
>
> Key: TWILL-24
> URL: https://issues.apache.org/jira/browse/TWILL-24
> Project: Apache Twill
> Issue Type: Improvement
> Components: api, core
> Reporter: Albert Shau
> Assignee: Henry Saputra
> Fix For: 0.6.0-incubating
>
>
> Currently the log level is fixed at info, so users have no way of looking at
> their log messages at lower levels.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
