Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/66#discussion_r44343897
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ApplicationBundler.java ---
@@ -145,41 +145,63 @@ public void createBundle(Location target, Class<?>
clz, Class<?>...classes) thro
* @throws IOException
*/
public void createBundle(Location target, Iterable<Class<?>> classes,
Iterable<URI> resources) throws IOException {
- LOG.debug("start creating bundle {}. building a temporary file locally
at first", target.getName());
+ createBundleAndGetClassPathUrls(target, classes, resources);
+ }
+
+ public Set<URL> createBundleAndGetClassPathUrls(Location target,
Iterable<Class<?>> classes,
+ Iterable<URI> resources)
throws IOException {
+ return createBundleAndGetClassPathUrls(target.getName(),
target.toString(),
+ target.getOutputStream(),
classes, resources);
+ }
+
+ private Set<URL> createBundleAndGetClassPathUrls(String targetName,
String targetPath,
+ OutputStream
targetOutputStream,
--- End diff --
If it takes output stream, then why need to take name and path? You either
take a `Location` or `File`, then create an output stream and manage and
closing it in this method, or you take a OutputStream and write to it, without
caring where does it actually output to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
