[ 
https://issues.apache.org/jira/browse/UIMA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905795#action_12905795
 ] 

Tommaso Teofili commented on UIMA-1861:
---------------------------------------

Thanks Marshall, this patch looks good to me :-) I agree with you that having 
typeSystem classes generated and retrieved from JCas sounds much better, I 
added Apache License headers to generated type system files and the 
testReconfigure() method inside SnowballAnnotatorTest to check that 
initialize() and reconfigure() work properly. Now committing the patch ;-)

> SnowballAnnotator needs refactoring
> -----------------------------------
>
>                 Key: UIMA-1861
>                 URL: https://issues.apache.org/jira/browse/UIMA-1861
>             Project: UIMA
>          Issue Type: Bug
>          Components: Sandbox-SnowballAnnotator
>    Affects Versions: 2.3.1
>            Reporter: Tommaso Teofili
>            Assignee: Tommaso Teofili
>             Fix For: 2.3.1
>
>         Attachments: SnowballAnnotatorPatch2.txt, UIMA1861-patch.txt
>
>
> SnowballAnnotator is extending the deprecated JTextAnnotator_ImplBase, have 
> some unused imports and generics should be enabled.
> Moreover the initialize() method fails due to the AnnotatorContext object 
> being null when run in a 2.3.1-SNAPSHOT distribution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to