+1 for the changes in DefaultCasDocumentProvider, it is just a small
nice change
to refactor the existing listener.
I am a little confused about the change you did to the ICasDocument and
its listener. Shouldn't the document change be announced by the editor
itself?
Otherwise a client, needs to swap its listener when a document changed,
and it is also
not the place I would look for a document changed event.
I suggest that we add a new listener which can be registered on the
ICasEditor
to announce ICasDocument swaps, what do you think?
Jörn
On 11/3/11 5:57 PM, Jörn Kottmann wrote:
On 11/3/11 5:45 PM, Peter Klügl wrote:
I worked with a strict formatting style for some years now, so it's
really ingrained.
I agree of course with your agruments and will take care that this
won't happen again.
Your editor still replaces tabs with spaces. According to our
guideline we should
use spaces. So we might just want let some source code clean up tool
exchange
them all at once, or tolerate them and fix them while we work on the
lines which contain them.
I am still reviewing your changes and will give feedback soon.
Jörn
