On 6/12/2013 3:55 AM, Richard Eckart de Castilho wrote: > As far as I understood, the motivation for the m2e build was to test > if the right output is produced in the build and if the plugin triggers > and endless build loop in m2e. Steven would need to say more about that, > I didn't write the tests. The integration tests do not even have asserts, > they just check if the builds terminate without errors. > > If we only care to make the build faster for the usual developer, then > we should disable it by default and keep it running on Jenkins. If we > care about load on Jenkins as well, we should completely disable it > and only turn it on manually when doing major changes. > > I'm fine with both ways. Given that the integration test for m2e involves very large network traffic as well, I'm disabling this one test (leaving the other 3 integration tests, though).
It's disabled in a not too good way - I commented out parts of its POM. Improvements welcome :-). -Marshall > -- Richard > > Am 12.06.2013 um 00:24 schrieb Marshall Schor <[email protected]>: > >> On 6/11/2013 3:57 PM, Richard Eckart de Castilho wrote: >>> The m2e integration test takes *very* long because it materializes a full >>> OSGI runtime environment on the machine. The downloads take forever. >>> >>> Detailed information about the execution of the integration tests can be >>> found in target/it/<test>/build.log (or something like that). >>> >>> I had considered disabling the m2e integration test, but went for leaving >>> it on for the time being. >> After taking another look at the tests, I would support disabling this one >> test, >> but leaving the others. (We can enable it temporarily when the jcasgen >> plugin >> project is updated, just to verify this build environment). >> >> In testing the jcasgen plugin, it seems to me that basic tests are to run >> this >> plugin in various maven build scenarios to see if it produces the right >> things >> (or at least doesn't crash). >> The m2e integration test simulates running a special maven build that Eclipse >> developers use, when developing the Eclipse platform, as I understand it >> (please >> correct as needed). Since the vast majority of our users are not in the >> world >> of Eclipse developers, perhaps that's not so important. >> >> And it also seems unlikely that that one form of test would fail while the >> others, which also run the jcasgen plugin in some different scenarios, would >> succeed. >> >> WDYT? -Marshall >
