Nice, I didn't know about Assume - I guess it's a feature of JUnit 4.x.y.
This change would skip the whole test. Since the test tests many things, such
as generating key pairs, and using them to encode and decode a message
(comparing the result), it would be better I think to be able to run the test.
-Marshall
On 11/26/2013 10:00 AM, Lou DeGenaro wrote:
> How about something like this in CryptoTest?:
>
> // ** Windows is not supported **
>
> @Before
> public void setUp() throws Exception {
> Assume.assumeTrue(!System.getProperty( "os.name" ).startsWith(
> "Windows" ));
> }
>
>
> On Tue, Nov 26, 2013 at 8:56 AM, Marshall Schor <[email protected]> wrote:
>
>> The "build" is breaking, not the running :-)
>>
>> The build (after you fixed it) now runs the test cases :-) So one of the
>> tests
>> fails because chmod routine throws an exception (it can't find the
>> executable,
>> duh, on windows).
>>
>> I don't think making this modification would indicate that running is
>> supported
>> on windows; we could add a comment, also, just to be clear.
>>
>> -Marshall
>> On 11/26/2013 7:48 AM, Lou DeGenaro wrote:
>>> Where exactly is this breaking...install, start? DUCC does not
>> officially
>>> (or unofficially) support Windows OS. Would adding such code
>> modifications
>>> indicate otherwise?
>>>
>>> Lou.
>>>
>>>
>>> On Mon, Nov 25, 2013 at 4:59 PM, Marshall Schor <[email protected]> wrote:
>>>
>>>> I put into my local copy a test inside the chmod method which does:
>>>>
>>>> String osName = System.getProperty("os.name");
>>>> if (osName.startsWith("Windows")) {
>>>> return;
>>>> }
>>>>
>>>> to bypass this on Windows... Should I commit this?
>>>>
>>>> -Marshall
>>>>
>>>> On 11/25/2013 3:40 PM, Marshall Schor wrote:
>>>>> I see that Java has some methods that claim to set permissions for
>> users
>>>> and
>>>>> "other" (but not group - that needs some Java 7 support). Perhaps
>> these
>>>> methods
>>>>> could be use in the Crypto class, to be more platform independent?
>>>>>
>>>>> -Marshall
>>>>>
>>>>> On 11/25/2013 2:07 PM, Marshall Schor wrote:
>>>>>> for testing it is more convenient for me to be able to build on
>>>> non-Linux
>>>>>> platforms, such as Windows.
>>>>>>
>>>>>> This used to work, but a recent change now runs a test which tries to
>>>> issue the
>>>>>> "chmod" command, and fails. Could this test be altered or somehow
>> made
>>>> to work
>>>>>> or be bypassed on Windows?
>>>>>>
>>>>>> -Marshall
>>
