[jira] [Comment Edited] (UIMA-5753) Get UIMA compile on Java 9 and higher

[Richard Eckart de Castilho (JIRA)]

    [ 
https://issues.apache.org/jira/browse/UIMA-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408745#comment-16408745
 ] 

Richard Eckart de Castilho edited comment on UIMA-5753 at 3/21/18 11:13 PM:
----------------------------------------------------------------------------

*org.apache.uima.analysis_engine.impl.AnalysisEngine_implTest.testManyDelegates()*
 - Java 9/10 adds additional line breaks after most elements. This test can be 
made to work by instantiating the XMLSerializer in manyDelegatesCommon with 
disabled output formatting. Just telling XMLUnit to ignore the whitespace does 
not work in this case because there is an additional assert which checks the 
size of the generated XML.

Expected:
{noformat}
<!--                                                               
    Descriptor for testing the editing and copying of an aggregate.
    
    Note: Blank lines outside comments in this first section are not preserved
    
    Note: The indent-amount is now 3 so the testManyDelagates JUnit test almost 
works with Saxon!
-->
<analysisEngineDescription xmlns="http://uima.apache.org/resourceSpecifier";>

   <frameworkImplementation>org.apache.uima.java</frameworkImplementation>
   <primitive>false</primitive>

   <!-- Test that order of declarations is preserved when re-written  -->
   <delegateAnalysisEngineSpecifiers>
      <delegateAnalysisEngine key="D">
         <import location="TestPrimitiveTae2.xml"/>
      </delegateAnalysisEngine>
      <delegateAnalysisEngine key="C">
         <import location="TestPrimitiveTae2.xml"/>
      </delegateAnalysisEngine>
...
{noformat}

Actual:
{noformat}
<!--                                                               
    Descriptor for testing the editing and copying of an aggregate.
    
    Note: Blank lines outside comments in this first section are not preserved
    
    Note: The indent-amount is now 3 so the testManyDelagates JUnit test almost 
works with Saxon!
-->
<analysisEngineDescription xmlns="http://uima.apache.org/resourceSpecifier";>
       
    <frameworkImplementation>org.apache.uima.java</frameworkImplementation>
       
    <primitive>false</primitive>
       
    <!-- Test that order of declarations is preserved when re-written  -->
       
    <delegateAnalysisEngineSpecifiers>
              
        <delegateAnalysisEngine key="D">
                     
            <import location="TestPrimitiveTae2.xml"/>
                  
        </delegateAnalysisEngine>
              
        <delegateAnalysisEngine key="C">
                     
            <import location="TestPrimitiveTae2.xml"/>
                  
        </delegateAnalysisEngine>
...
{noformat}


was (Author: rec):
*org.apache.uima.analysis_engine.impl.AnalysisEngine_implTest.testManyDelegates()*
 - Java 9/10 adds additional line breaks after most elements. This test can be 
made to work by instantiating the XMLSerializer in manyDelegatesCommon with 
disabled output formatting.

Expected:
{noformat}
<!--                                                               
    Descriptor for testing the editing and copying of an aggregate.
    
    Note: Blank lines outside comments in this first section are not preserved
    
    Note: The indent-amount is now 3 so the testManyDelagates JUnit test almost 
works with Saxon!
-->
<analysisEngineDescription xmlns="http://uima.apache.org/resourceSpecifier";>

   <frameworkImplementation>org.apache.uima.java</frameworkImplementation>
   <primitive>false</primitive>

   <!-- Test that order of declarations is preserved when re-written  -->
   <delegateAnalysisEngineSpecifiers>
      <delegateAnalysisEngine key="D">
         <import location="TestPrimitiveTae2.xml"/>
      </delegateAnalysisEngine>
      <delegateAnalysisEngine key="C">
         <import location="TestPrimitiveTae2.xml"/>
      </delegateAnalysisEngine>
...
{noformat}

Actual:
{noformat}
<!--                                                               
    Descriptor for testing the editing and copying of an aggregate.
    
    Note: Blank lines outside comments in this first section are not preserved
    
    Note: The indent-amount is now 3 so the testManyDelagates JUnit test almost 
works with Saxon!
-->
<analysisEngineDescription xmlns="http://uima.apache.org/resourceSpecifier";>
       
    <frameworkImplementation>org.apache.uima.java</frameworkImplementation>
       
    <primitive>false</primitive>
       
    <!-- Test that order of declarations is preserved when re-written  -->
       
    <delegateAnalysisEngineSpecifiers>
              
        <delegateAnalysisEngine key="D">
                     
            <import location="TestPrimitiveTae2.xml"/>
                  
        </delegateAnalysisEngine>
              
        <delegateAnalysisEngine key="C">
                     
            <import location="TestPrimitiveTae2.xml"/>
                  
        </delegateAnalysisEngine>
...
{noformat}

> Get UIMA compile on Java 9 and higher
> -------------------------------------
>
>                 Key: UIMA-5753
>                 URL: https://issues.apache.org/jira/browse/UIMA-5753
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Core Java Framework
>    Affects Versions: 2.10.2SDK
>            Reporter: Richard Eckart de Castilho
>            Priority: Minor
>
> Since meanwhile Java 10 has been released, seems like a good idea to get the 
> build finally running on Java 9 and higher.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)