[
https://issues.apache.org/jira/browse/UIMA-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556216#comment-16556216
]
Richard Eckart de Castilho commented on UIMA-5845:
--------------------------------------------------
I think that the difference between `get`and `single` would be that the first
may return null whereas the second does throw an exception. Actually, I'm not
sure why we need a `nullOK` flag given this distinction. So I'd be to change it
such that `get` never throws an exception (unless `nullOK` is set in case we
actually keep it). I suppose the "modern" approach to this would be to have a
single method (e.g. `single()`) which would return an `Optional` (leading to a
`.single().get()`). But it may be a bit late now to do this kind of API
adjustments (I didn't choose `get` because `Optional` has a `get` and
`get().get()` looks bad).
> Inconsistent behavior on going beyond index limits in SelectFS
> --------------------------------------------------------------
>
> Key: UIMA-5845
> URL: https://issues.apache.org/jira/browse/UIMA-5845
> Project: UIMA
> Issue Type: Bug
> Components: Core Java Framework
> Affects Versions: 3.0.0SDK
> Reporter: Richard Eckart de Castilho
> Priority: Major
>
> The behavior of trying to address annotations outside the index appears to be
> inconsistent.
> For example, the following call returns `null`:
> {code}
> String text = "one two three";
> tokenBuilder.buildTokens(jCas, text);
> List<Token> tokens = new ArrayList<Token>(select(jCas, Token.class));
>
> for (Token token : tokens) {
> new AnalyzedText(jCas, token.getBegin(), token.getEnd()).addToIndexes();
> }
>
> Token firstToken = tokens.get(0);
> AnalyzedText x = jCas.select(AnalyzedText.class).preceding(firstToken,
> 0).get();
> {code}
> However, this code trying go from the end of the index to before the first
> item throws a CASRuntime exception:
> {code}
> String text = "Rot wood cheeses dew?";
> tokenBuilder.buildTokens(jCas, text);
> assertThatExceptionOfType(CASRuntimeException.class)
> .isThrownBy(() -> jCas.select(Token.class).backwards().get(4))
> .withMessage("CAS does not contain any '" + Token.class.getName() +
> "' instances shifted by: 4.");
> {code}
> It would seem reasonably to either always return null or to always thrown an
> exception. If an exception is thrown, it would seem reasonable to introduce a
> subtype of the CASRuntimeException, e.g. a CASIndexOutOfBounds exception or
> something the likes. CASRuntimeException seems very general.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
