[ 
https://issues.apache.org/jira/browse/UIMA-6057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864381#comment-16864381
 ] 

Marshall Schor commented on UIMA-6057:
--------------------------------------

I looked at the patch.  

It changes the switcher to return a boolean saying if it was switched.

The switch back is augmented to test a passed-in parameter (was_switched) - if 
that's set, then the switch back works like before - testing to see if the 
previous loader is different, etc.

If the parameter is false, then the switch back won't happen (even if the 
previous loader is different).  

In the framework code, as you've pointed out, this parameter is not needed, and 
is redundant. I presume in some Ruta context, it is set false to block the 
switching back.  Is that correct?

I'd like to document this as clearly as possible for future maintainers.

> Avoid falsely switching classloader
> -----------------------------------
>
>                 Key: UIMA-6057
>                 URL: https://issues.apache.org/jira/browse/UIMA-6057
>             Project: UIMA
>          Issue Type: Bug
>            Reporter: Matthias Koch
>            Priority: Major
>         Attachments: UIMA-6057.diff
>
>
> In some cases the classloader is switched back, although it hasn't be 
> switched before processing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to