I just closed / commented on some older uimaj pull requests, and guess what: the Jira was updated with a link to the comment :-)
-Marshall On 9/9/2019 3:36 PM, Richard Eckart de Castilho wrote: > On 9. Sep 2019, at 21:24, Marshall Schor <m...@schor.com> wrote: >> If there's a discussion on a pull request, is it "linked" into the related >> Jira >> (assuming the pull request follows the naming conventions)? > I don't know of any convention to link a PR to a Jira in such a way that the > Jira > is automatically updated. > > When working purely with GitHub (non-ASF), the issue describes a problem and > potentially a desired solution while the PR discusses the actual > implementation. > Of course, it is often difficult in practice to have black/white boundaries. > >> If not, is the recommended practice to put the commentary in the Jira, >> perhaps >> with a pointer to it in the github pull request "review"? > The PR has the benefit of allowing line comments. So as part of the "review", > it > often happens that I read the changes in detail and then comment on > individual > changes. Often, these comments become short threads within the review. These > thread can be resolved individually. Once all comments are addressed, I > approve > the PR and merge it. Jira doesn't allow this kind of fine-grained review. > > Here you can see such a line comment rendered in the PR view: > > - https://github.com/apache/opennlp/pull/227 > > here you can see some more in a pure GitHub project (non-ASF): > > - https://github.com/inception-project/inception/pull/1320 > > -- Richard
