reckart commented on a change in pull request #39:
URL: https://github.com/apache/uima-uimaj/pull/39#discussion_r419742881



##########
File path: uimaj-core/src/main/java/org/apache/uima/pear/util/XMLUtil.java
##########
@@ -828,4 +862,18 @@ public static void printXMLTag(String tag, Properties 
attributes, PrintWriter oW
     oWriter.print('>');
     oWriter.flush();
   }
+  
+  private static String xmlEscape(String value)
+  {
+      if (value == null) {
+          return value;
+      }
+      
+      return value
+              .replace("&", "&")

Review comment:
       Btw. I was considering to use XML escaping methods form commons-lang3 or 
commons-text, but didn't want to introduce the dependency. I was also 
considering to port this whole stuff over to Xmlizable (i.e what other UIMA 
descriptors use) or even JAXB - but again, it seemed to much for the time being.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to