zuston commented on code in PR #9:
URL: https://github.com/apache/incubator-uniffle/pull/9#discussion_r912433417
##########
common/src/main/java/com/tencent/rss/common/config/RssConf.java:
##########
@@ -576,7 +576,7 @@ public <T> Optional<T> getOptional(ConfigOption<T> option) {
return value;
}
Review Comment:
Although the RssConf impl looks like the Flink conf, but the convert method
is different. That means we shouldn't do the convert action in `getOptional`
method, just to init it in `TypedConfigOptionBuilder` or
`ListConfigOptionBuilder`.
Now in current PR, i dont implement the case like
`conf.set(listStringOption, List("a", "b", c))`. I think i can support it in
the `ListConfigOptionBuilder` directly. No need to change the `getOptional`
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
