jerqi commented on code in PR #30:
URL: https://github.com/apache/incubator-uniffle/pull/30#discussion_r913771982
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -157,8 +159,18 @@ private void initialization() throws Exception {
setServer();
+ setServerTags();
+ }
+
+ private void setServerTags() {
Review Comment:
Method `initServerTags()` may be better. `setServerTags` is like a setter. A
setter should have an input parameter in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
