smallzhongfeng opened a new issue, #376:
URL: https://github.com/apache/incubator-uniffle/issues/376

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Describe the bug
   
   ```
   appAndTime.remove(uuidFromApp);
   appAndTime.put(appId, currentTimeMillis);
   ```
   In the process of app registration, we need to remove the uuid and re insert 
it into the registered appId. This process is not atomic and may cause 
concurrency problems.
   ```
    int currentAppNum = appAndTimes.size();
    if (currentAppNum >= defaultAppNum) {
       ...
   }
   ```
   When getting `appAndTimes`, it may be the number of apps before putting 
appId after removing uuid.
   
   
   ### Affects Version(s)
   
   0.7.0
   
   ### Uniffle Server Log Output
   
   _No response_
   
   ### Uniffle Engine Log Output
   
   _No response_
   
   ### Uniffle Server Configurations
   
   _No response_
   
   ### Uniffle Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to